Fix for issue 21398 (only send "literal like" objects across isolates spawned using spawnURI

Fix for issue 21398.

Accept only 'literal-like' objects when sending messages to isolates
spawned using spawnURI. Allow all objects for isolates spawned using
spawnFunction.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42793

[siva, 2015-01-07 00:23:11]

asiva@google.com changed reviewers:
+ iposva@google.com

[siva, 2015-01-07 17:20:11]

synched to tot.

[Ivan Posva, 2015-01-08 23:53:59]

As discussed offline we will need to be able to transfer send ports through
isolates that have not been spawned from the same origin, so another solution is
needed.

-Ivan

[siva, 2015-01-09 22:58:13]

replaced boolean field with origin id in the SendPort object as discussed.

PTAL.

[Ivan Posva, 2015-01-12 05:50:04]

LGTM with comments.

-Ivan

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/service.cc#n...
runtime/vm/service.cc:276: const SendPort& send_port =
SendPort::Handle(SendPort::New(port_id, false));
false? Shouldn't the second parameter to a SendPort::New be a port id?

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/service.cc#n...
runtime/vm/service.cc:317: const SendPort& send_port =
SendPort::Handle(SendPort::New(port_id, false));
ditto

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:1043: bool can_send_any_object) :
Formatting is off.
Foo::Foo(param)
    : first_(1),
      second_(2) {
  statements;
}

https://codereview.chromium.org/834233003/diff/140001/tests/isolate/issue_213...
File tests/isolate/issue_21398_child_isolate.dart (right):

https://codereview.chromium.org/834233003/diff/140001/tests/isolate/issue_213...
tests/isolate/issue_21398_child_isolate.dart:13: var sendPort = message as
SendPort;
Why is the "as SendPort" necessary here?

[siva, 2015-01-12 21:41:14]

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/service.cc#n...
runtime/vm/service.cc:276: const SendPort& send_port =
SendPort::Handle(SendPort::New(port_id, false));
On 2015/01/12 05:50:04, Ivan Posva wrote:
> false? Shouldn't the second parameter to a SendPort::New be a port id?

Good point, left over from my previous version,
changed this to be just SendPort::New(port_id);

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/service.cc#n...
runtime/vm/service.cc:317: const SendPort& send_port =
SendPort::Handle(SendPort::New(port_id, false));
On 2015/01/12 05:50:04, Ivan Posva wrote:
> ditto

ditto.

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/834233003/diff/140001/runtime/vm/snapshot.cc#...
runtime/vm/snapshot.cc:1043: bool can_send_any_object) :
On 2015/01/12 05:50:04, Ivan Posva wrote:
> Formatting is off.
> Foo::Foo(param)
>     : first_(1),
>       second_(2) {
>   statements;
> }

Fixed.

https://codereview.chromium.org/834233003/diff/140001/tests/isolate/issue_213...
File tests/isolate/issue_21398_child_isolate.dart (right):

https://codereview.chromium.org/834233003/diff/140001/tests/isolate/issue_213...
tests/isolate/issue_21398_child_isolate.dart:13: var sendPort = message as
SendPort;
On 2015/01/12 05:50:04, Ivan Posva wrote:
> Why is the "as SendPort" necessary here?

Not really necessary, removed it.

[siva, 2015-01-12 22:51:40]

Updated isolate.status file to account test status for other runtimes.

[siva, 2015-01-12 23:14:45]

Committed patchset #10 (id:180001) manually as r42793 (presubmit successful).