Analysis server format service wiring (and protocol doc update).

Analysis server format service wiring (and protocol doc update).

R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42835

[pquitslund, 2015-01-13 18:54:07]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

[pquitslund, 2015-01-13 18:54:08]

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:67: }
Comments welcome especially on error handling.  Should I add more?

[scheglov, 2015-01-13 19:19:53]

LGTM

[Brian Wilkerson, 2015-01-13 19:29:47]

LGTM

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:70:
engine.TimestampedData<String> contents = context.getContents(source);
The method getContents will throw an exception if the contents cannot be
accessed (for example, if the file doesn't exist). This should be wrapped in a
try/catch and a formatInvalidFile response should be returned.

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:86: SourceEdit edit =
Perhaps add a TODO to consider producing more efficient results (smaller edits).
A discussion of the techniques we've discussed would be good, just so we don't
forget.

[danrubel, 2015-01-13 19:30:50]

lgtm

[danrubel, 2015-01-13 19:35:18]

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:26: import
'package:dart_style/dart_style.dart';
Do we need to update the analysis_server pubspec?

[pquitslund, 2015-01-13 20:06:55]

Thanks!

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/edit/edit_domain.dart (right):

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:26: import
'package:dart_style/dart_style.dart';
On 2015/01/13 19:35:18, danrubel wrote:
> Do we need to update the analysis_server pubspec?

Why not!  Done.

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:70:
engine.TimestampedData<String> contents = context.getContents(source);
On 2015/01/13 19:29:47, Brian Wilkerson wrote:
> The method getContents will throw an exception if the contents cannot be
> accessed (for example, if the file doesn't exist). This should be wrapped in a
> try/catch and a formatInvalidFile response should be returned.

Done.

https://codereview.chromium.org/833903005/diff/40001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/edit/edit_domain.dart:86: SourceEdit edit =
On 2015/01/13 19:29:47, Brian Wilkerson wrote:
> Perhaps add a TODO to consider producing more efficient results (smaller
edits).
> A discussion of the techniques we've discussed would be good, just so we don't
> forget.

Done.

[pquitslund, 2015-01-13 20:34:19]

Committed patchset #4 (id:60001) manually as r42835 (presubmit successful).