Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 832713006: Double-align Zone allocations to fix MIPS issue. (Closed)

Created:
5 years, 11 months ago by koda
Modified:
5 years, 11 months ago
Reviewers:
zra, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra
Visibility:
Public.

Description

Double-align Zone allocations to fix MIPS issue. Also ensure initial buffer is aligned. ~2% increase in total allocated zone memory on compile-heavy benchmarks. No significant impact on speed for either ia32 or arm. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42797

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M runtime/vm/globals.h View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/zone.h View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/zone.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
koda
5 years, 11 months ago (2015-01-12 21:12:20 UTC) #1
Ivan Posva
LGTM -ip
5 years, 11 months ago (2015-01-13 00:07:24 UTC) #2
koda
Committed patchset #2 (id:20001) manually as r42797 (presubmit successful).
5 years, 11 months ago (2015-01-13 01:56:34 UTC) #3
zra
5 years, 11 months ago (2015-01-14 15:44:20 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698