Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 832583003: tools: Refactored SummaryReport and move it to its own library (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

tools: Refactored SummaryReport and move it to its own library R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=42826

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -107 lines) Patch
A tools/testing/dart/summary_report.dart View 1 1 chunk +130 lines, -0 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 3 chunks +3 lines, -105 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 11 months ago (2015-01-12 18:41:54 UTC) #2
ricow1
lgtm https://codereview.chromium.org/832583003/diff/1/tools/testing/dart/summary_report.dart File tools/testing/dart/summary_report.dart (right): https://codereview.chromium.org/832583003/diff/1/tools/testing/dart/summary_report.dart#newcode1 tools/testing/dart/summary_report.dart:1: library summary_report; add copyright header https://codereview.chromium.org/832583003/diff/1/tools/testing/dart/summary_report.dart#newcode85 tools/testing/dart/summary_report.dart:85: _nonStandardTestCases.add(testCase); ...
5 years, 11 months ago (2015-01-13 07:47:14 UTC) #3
kevmoo
https://codereview.chromium.org/832583003/diff/1/tools/testing/dart/summary_report.dart File tools/testing/dart/summary_report.dart (right): https://codereview.chromium.org/832583003/diff/1/tools/testing/dart/summary_report.dart#newcode1 tools/testing/dart/summary_report.dart:1: library summary_report; On 2015/01/13 07:47:13, ricow1 wrote: > add ...
5 years, 11 months ago (2015-01-13 17:46:42 UTC) #4
kevmoo
5 years, 11 months ago (2015-01-13 17:46:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42826 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698