Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 832383002: Update the documentation for FielSystemEntity.resolveSymbolicLinks (Closed)

Created:
5 years, 11 months ago by Søren Gjesse
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Update the documentation for FielSystemEntity.resolveSymbolicLinks The platform difference was the opposite of what was documented. With the following directory structure /tmp/xxx a/b x -> a/b resolving x/.. on Windows results in /tmp/xxx and on Linux results in /tmp/xxx/a. Resolving just x results in /tmp/xxx/a/b on both platforms. R=whesse@google.com, lrn@google.com BUG=http://dartbug.com/21967 Committed: https://code.google.com/p/dart/source/detail?r=42725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -29 lines) Patch
M sdk/lib/io/file_system_entity.dart View 2 chunks +45 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
5 years, 11 months ago (2015-01-05 15:15:00 UTC) #1
Bill Hesse
LGTM. This behavior is tested in standalone/io/resolve_symbolic_links_test.dart, and the test, and comments, are correct, and ...
5 years, 11 months ago (2015-01-05 15:49:29 UTC) #2
Søren Gjesse
5 years, 11 months ago (2015-01-09 08:20:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42725 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698