Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 832343004: Issue 21959. Check that type of parameters in 'Extract Method' occurrences are exactly the same. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Issue 21959. Check that type of parameters in 'Extract Method' occurrences are exactly the same. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=21959 Committed: https://code.google.com/p/dart/source/detail?r=42615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 7 chunks +25 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 11 months ago (2015-01-05 20:48:12 UTC) #1
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-05 23:11:10 UTC) #2
scheglov
5 years, 11 months ago (2015-01-05 23:12:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42615 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698