Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 832343002: fix top level getter suggestions (Closed)

Created:
5 years, 11 months ago by danrubel
Modified:
5 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

fix top level getter suggestions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42597

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 11 months ago (2015-01-05 07:06:16 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-05 15:51:31 UTC) #3
danrubel
5 years, 11 months ago (2015-01-05 15:55:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698