Issue 832173009: Unit tests for 'testb' instruction on ia32 and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 832173009: Unit tests for 'testb' instruction on ia32 and x64. (Closed)

Created:
5 years, 11 months ago by koda

Modified:
5 years, 11 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Unit tests for 'testb' instruction on ia32 and x64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=42742

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	runtime/vm/assembler_ia32_test.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download
	M	runtime/vm/assembler_x64_test.cc	View		1 chunk	+24 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM Thanks! https://codereview.chromium.org/832173009/diff/1/runtime/vm/assembler_x64_test.cc File runtime/vm/assembler_x64_test.cc (right): https://codereview.chromium.org/832173009/diff/1/runtime/vm/assembler_x64_test.cc#newcode310 runtime/vm/assembler_x64_test.cc:310: __ j(ZERO, &done); I guess cmovneq is ...

5 years, 11 months ago (2015-01-09 16:30:39 UTC) #2

koda

https://codereview.chromium.org/832173009/diff/1/runtime/vm/assembler_x64_test.cc File runtime/vm/assembler_x64_test.cc (right): https://codereview.chromium.org/832173009/diff/1/runtime/vm/assembler_x64_test.cc#newcode310 runtime/vm/assembler_x64_test.cc:310: __ j(ZERO, &done); On 2015/01/09 16:30:39, regis wrote: > ...

5 years, 11 months ago (2015-01-09 16:37:07 UTC) #3

koda

5 years, 11 months ago (2015-01-09 17:22:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r42742 (presubmit successful).

Expand Messages | Collapse Messages