Make withLocale use a zone

Make withLocale use a zone

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/intl/commit/4ce7dc603f664928a65746424725430bd55f959a

[Alan Knight, 2015-01-02 19:37:38]

alanknight@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-01-02 20:36:48]

lgtm

https://codereview.chromium.org/832073002/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/832073002/diff/20001/CHANGELOG.md#newcode3
CHANGELOG.md:3: inside withLocale also get the correct locale.
should this be considered a breaking change? Or maybe highlight that this is
more a bugfix?

https://codereview.chromium.org/832073002/diff/20001/lib/intl.dart
File lib/intl.dart (right):

https://codereview.chromium.org/832073002/diff/20001/lib/intl.dart#newcode98
lib/intl.dart:98: var zoneLocale = Zone.current[#Intl_locale];
how about #intl.locale? or #IntlLocale ?

https://codereview.chromium.org/832073002/diff/20001/lib/intl.dart#newcode357
lib/intl.dart:357: * The [function] might just returns the result of
`Intl.message()` or
rephrase this paragraph? (grammar seems a bit odd after the restructuring. For
example, returns => return, doing => do)

[Alan Knight, 2015-01-02 20:50:13]

https://codereview.chromium.org/832073002/diff/20001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/832073002/diff/20001/CHANGELOG.md#newcode3
CHANGELOG.md:3: inside withLocale also get the correct locale.
On 2015/01/02 20:36:48, Siggi Cherem (dart-lang) wrote:
> should this be considered a breaking change? Or maybe highlight that this is
> more a bugfix?

I think it was kind of broken before, but made the version be 0.12.0 since this
is behavior-changing.

https://codereview.chromium.org/832073002/diff/20001/lib/intl.dart
File lib/intl.dart (right):

https://codereview.chromium.org/832073002/diff/20001/lib/intl.dart#newcode98
lib/intl.dart:98: var zoneLocale = Zone.current[#Intl_locale];
On 2015/01/02 20:36:48, Siggi Cherem (dart-lang) wrote:
> how about #intl.locale? or #IntlLocale ?

I had just assumed I couldn't use a period in a symbol. Changed to #Intl.locale

https://codereview.chromium.org/832073002/diff/20001/lib/intl.dart#newcode357
lib/intl.dart:357: * The [function] might just returns the result of
`Intl.message()` or
On 2015/01/02 20:36:48, Siggi Cherem (dart-lang) wrote:
> rephrase this paragraph? (grammar seems a bit odd after the restructuring. For
> example, returns => return, doing => do)

Oops. Cleaned up, and removed some of the explanatory text. The examples are
better than trying to write out an explanation of the possibilities.

[Sean Eagan, 2015-01-02 21:05:30]

https://codereview.chromium.org/832073002/diff/40001/lib/intl.dart
File lib/intl.dart (right):

https://codereview.chromium.org/832073002/diff/40001/lib/intl.dart#newcode101
lib/intl.dart:101: static set defaultLocale(String newLocale) => _defaultLocale
= newLocale;
Can this be deprecated now?  It seems like `withLocale` now covers all use cases
in a safer way than setting `defaultLocale` directly.  If it is kept, it might
be good to note that setting `defaultLocale` has no effect within `withLocale`
zones and might even make sense to throw if someone tries to do that.

[Alan Knight, 2015-01-02 21:53:33]

https://codereview.chromium.org/832073002/diff/40001/lib/intl.dart
File lib/intl.dart (right):

https://codereview.chromium.org/832073002/diff/40001/lib/intl.dart#newcode101
lib/intl.dart:101: static set defaultLocale(String newLocale) => _defaultLocale
= newLocale;
On 2015/01/02 21:05:30, Sean Eagan wrote:
> Can this be deprecated now?  It seems like `withLocale` now covers all use
cases
> in a safer way than setting `defaultLocale` directly.  If it is kept, it might
> be good to note that setting `defaultLocale` has no effect within `withLocale`
> zones and might even make sense to throw if someone tries to do that.

I think it's reasonable for the simple case that you set the locale once at the
beginning, perhaps from the browser settings or the user settings and then don't
change it, that you just set defaultLocale. And there are definitely people
calling that, so I'm reluctant to deprecate it. But I did put a comment on it
and in the README that withLocale is preferable if using multiple locales within
an app, and mentioning that it supercedes defaultLocale while it is active.

[Alan Knight, 2015-01-03 00:14:01]

Committed patchset #4 (id:60001) manually as
4ce7dc603f664928a65746424725430bd55f959a (presubmit successful).