Issue 831983005: Properly detect if git revisions aren't in a git repository.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 831983005: Properly detect if git revisions aren't in a git repository. (Closed)

Created:
5 years, 11 months ago by nweiz

Modified:
5 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Properly detect if git revisions aren't in a git repository. R=rnystrom@google.com BUG=20947 Committed: https://code.google.com/p/dart/source/detail?r=42936

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -47 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/source/git.dart	View	2 chunks	+14 lines, -7 lines	0 comments	Download
A +	sdk/lib/_internal/pub/test/get/git/check_out_unfetched_revision_of_cached_repo_test.dart	View	3 chunks	+22 lines, -15 lines	0 comments	Download
M	sdk/lib/_internal/pub_generated/lib/src/source/git.dart	View	2 chunks	+14 lines, -10 lines	0 comments	Download
A +	sdk/lib/_internal/pub_generated/test/get/git/check_out_unfetched_revision_of_cached_repo_test.dart	View	2 chunks	+24 lines, -15 lines	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 11 months ago (2015-01-15 21:58:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42936 (presubmit successful).