Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Issue 83173012: Fix docgen Uri handling so it works on Windows. (Closed)

Created:
7 years, 1 month ago by aam-me
Modified:
7 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix test so it passes Uri of the file rather than string filename. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M pkg/docgen/lib/docgen.dart View 8 chunks +15 lines, -19 lines 0 comments Download
M pkg/docgen/test/single_library_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
aam-me
Hi, I bumped into docgen build problem on my Windows box. Have a fix here. ...
7 years, 1 month ago (2013-11-24 04:31:44 UTC) #1
Emily Fortuna
lgtm, thanks! I had noticed a number of Windows issues with that code -- thanks ...
7 years ago (2013-11-25 16:39:57 UTC) #2
Alan Knight
lgtm I don't completely love the mixing and matching path and URI operations but we ...
7 years ago (2013-11-25 17:32:37 UTC) #3
aam-me
Committed patchset #1 manually as r30634 (presubmit successful).
7 years ago (2013-11-25 17:33:43 UTC) #4
aam-me
Thank you for the review, Alan, Emily. I had to revert patchset #1 because of ...
7 years ago (2013-11-25 18:39:30 UTC) #5
Alan Knight
lgtm
7 years ago (2013-11-25 18:41:44 UTC) #6
Emily Fortuna
lgtm
7 years ago (2013-11-25 20:07:50 UTC) #7
aam-me
7 years ago (2013-11-25 21:00:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r30644 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698