Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 83173003: Read up to 8 InterruptMessages at a time, in unix eventhandlers. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Read up to 8 InterruptMessages at a time, in unix eventhandlers. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30574

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -64 lines) Patch
M runtime/bin/eventhandler_android.cc View 1 2 2 chunks +17 lines, -20 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 2 2 chunks +19 lines, -22 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 2 chunks +19 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-11-22 12:30:48 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/83173003/diff/80001/runtime/bin/eventhandler_android.cc File runtime/bin/eventhandler_android.cc (right): https://codereview.chromium.org/83173003/diff/80001/runtime/bin/eventhandler_android.cc#newcode187 runtime/bin/eventhandler_android.cc:187: for (ssize_t i = 0; i < bytes ...
7 years, 1 month ago (2013-11-22 12:40:23 UTC) #2
Anders Johnsen
https://codereview.chromium.org/83173003/diff/80001/runtime/bin/eventhandler_android.cc File runtime/bin/eventhandler_android.cc (right): https://codereview.chromium.org/83173003/diff/80001/runtime/bin/eventhandler_android.cc#newcode187 runtime/bin/eventhandler_android.cc:187: for (ssize_t i = 0; i < bytes / ...
7 years, 1 month ago (2013-11-22 12:50:21 UTC) #3
Anders Johnsen
7 years, 1 month ago (2013-11-22 12:50:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r30574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698