Issue 831423006: Append the regexp pattern to the name of the generated irregexp function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 831423006: Append the regexp pattern to the name of the generated irregexp function. (Closed)

Created:
5 years, 11 months ago by zerny-google

Modified:
5 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Append the regexp pattern to the name of the generated irregexp function. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42805

Patch Set 2 : handle #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	runtime/vm/regexp.cc	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
	M	runtime/vm/symbols.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://codereview.chromium.org/831423006/diff/1/runtime/vm/regexp.cc File runtime/vm/regexp.cc (right): https://codereview.chromium.org/831423006/diff/1/runtime/vm/regexp.cc#newcode5107 runtime/vm/regexp.cc:5107: String::ZoneHandle(isolate, String::Concat( Why use a ZoneHandle here?

5 years, 11 months ago (2015-01-13 13:06:28 UTC) #2

zerny-google

Thanks for the review. https://codereview.chromium.org/831423006/diff/1/runtime/vm/regexp.cc File runtime/vm/regexp.cc (right): https://codereview.chromium.org/831423006/diff/1/runtime/vm/regexp.cc#newcode5107 runtime/vm/regexp.cc:5107: String::ZoneHandle(isolate, String::Concat( On 2015/01/13 13:06:28, ...

5 years, 11 months ago (2015-01-13 13:24:51 UTC) #3

zerny-google

5 years, 11 months ago (2015-01-13 13:32:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42805 (presubmit successful).

Expand Messages | Collapse Messages

Issue 831423006: Append the regexp pattern to the name of the generated irregexp function. (Closed)

Description

Patch Set 1 #

Patch Set 2 : handle #

Messages