Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 831263007: Getter elements should not have parameters. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Getter elements should not have parameters. R=danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 11 months ago (2015-01-05 22:11:12 UTC) #1
danrubel
lgtm
5 years, 11 months ago (2015-01-05 23:19:32 UTC) #2
scheglov
5 years, 11 months ago (2015-01-05 23:22:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698