Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 831093005: reformatted, remove unused fields and imports, updated readme (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/path.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

reformatted, remove unused fields and imports, updated readme and fixed codereview.settings R=nweiz@google.com Committed: https://github.com/dart-lang/path/commit/268334e45661f093b6c435fa326d661d09eff1c5

Patch Set 1 #

Patch Set 2 : updated version #

Patch Set 3 : updated readme code formatting #

Patch Set 4 : rebase #

Total comments: 2

Patch Set 5 : cl nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -166 lines) Patch
M README.md View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M benchmark/benchmark.dart View 1 2 3 4 1 chunk +1 line, -5 lines 0 comments Download
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M lib/path.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/src/context.dart View 11 chunks +25 lines, -19 lines 0 comments Download
M lib/src/parsed_path.dart View 4 chunks +6 lines, -10 lines 0 comments Download
M lib/src/style/url.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M lib/src/style/windows.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/browser_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M test/io_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/posix_test.dart View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M test/relative_test.dart View 2 chunks +10 lines, -11 lines 0 comments Download
M test/url_test.dart View 1 2 3 21 chunks +47 lines, -56 lines 0 comments Download
M test/windows_test.dart View 1 2 3 10 chunks +29 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 11 months ago (2015-01-13 21:17:31 UTC) #2
kevmoo
PTAL
5 years, 11 months ago (2015-01-13 21:26:12 UTC) #3
nweiz
lgtm https://codereview.chromium.org/831093005/diff/60001/benchmark/benchmark.dart File benchmark/benchmark.dart (right): https://codereview.chromium.org/831093005/diff/60001/benchmark/benchmark.dart#newcode51 benchmark/benchmark.dart:51: const COMMON_PATHS = const ['.', '..', 'out/ReleaseIA32/packages',]; Remove ...
5 years, 11 months ago (2015-01-13 21:37:34 UTC) #4
kevmoo
https://codereview.chromium.org/831093005/diff/60001/benchmark/benchmark.dart File benchmark/benchmark.dart (right): https://codereview.chromium.org/831093005/diff/60001/benchmark/benchmark.dart#newcode51 benchmark/benchmark.dart:51: const COMMON_PATHS = const ['.', '..', 'out/ReleaseIA32/packages',]; On 2015/01/13 ...
5 years, 11 months ago (2015-01-13 21:39:48 UTC) #5
kevmoo
5 years, 11 months ago (2015-01-13 21:40:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
268334e45661f093b6c435fa326d661d09eff1c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698