Issue 83093004: Fix shutdown races and move signal blocking into profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83093004: Fix shutdown races and move signal blocking into profiler (Closed)

Created:
7 years, 1 month ago by Cutch

Modified:
7 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

- Fix shutdown race. - Move signal blocking out of dart.cc and isolate.cc and into profiler.cc. - Nest scope objects explicitly. - Add missing signal block in ProfilerManager::ShutdownIsolateForProfiling. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30602

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -173 lines)			Patch
M	runtime/vm/dart.cc	View	1 2	2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2 3 4	4 chunks	+1 line, -7 lines	0 comments	Download
M	runtime/vm/profiler.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/profiler.cc	View	1 2 3	12 chunks	+198 lines, -160 lines	0 comments	Download
M	runtime/vm/profiler_android.cc	View	1 2 3	2 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/profiler_linux.cc	View	1 2 3	3 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/profiler_macos.cc	View	1 2 3	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

https://codereview.chromium.org/83093004/diff/60001/runtime/vm/profiler.cc File runtime/vm/profiler.cc (left): https://codereview.chromium.org/83093004/diff/60001/runtime/vm/profiler.cc#oldcode448 runtime/vm/profiler.cc:448: thread_id_ = 0; Only update the thread_id when scheduled. ...

7 years, 1 month ago (2013-11-22 23:30:18 UTC) #1

Cutch

7 years, 1 month ago (2013-11-23 00:26:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r30602 (presubmit successful).

Expand Messages | Collapse Messages