Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 830923003: dart2js: make "boilerplate" function in Native generator. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, sra1
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: make "boilerplate" function in Native generator. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=42629

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -37 lines) Patch
M pkg/compiler/lib/src/js_emitter/native_generator.dart View 1 2 2 chunks +25 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 1 chunk +8 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
Depends on https://codereview.chromium.org/829473003/
5 years, 11 months ago (2015-01-05 15:12:26 UTC) #2
sra1
lgtm https://codereview.chromium.org/830923003/diff/20001/pkg/compiler/lib/src/js_emitter/native_generator.dart File pkg/compiler/lib/src/js_emitter/native_generator.dart (right): https://codereview.chromium.org/830923003/diff/20001/pkg/compiler/lib/src/js_emitter/native_generator.dart#newcode9 pkg/compiler/lib/src/js_emitter/native_generator.dart:9: static jsAst.Statement generateBoilerPlate( Can we come up with ...
5 years, 11 months ago (2015-01-05 18:55:47 UTC) #3
floitsch
https://codereview.chromium.org/830923003/diff/20001/pkg/compiler/lib/src/js_emitter/native_generator.dart File pkg/compiler/lib/src/js_emitter/native_generator.dart (right): https://codereview.chromium.org/830923003/diff/20001/pkg/compiler/lib/src/js_emitter/native_generator.dart#newcode9 pkg/compiler/lib/src/js_emitter/native_generator.dart:9: static jsAst.Statement generateBoilerPlate( On 2015/01/05 18:55:47, sra1 wrote: > ...
5 years, 11 months ago (2015-01-06 12:33:56 UTC) #4
floitsch
5 years, 11 months ago (2015-01-06 12:34:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42629 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698