Emit to StreamCodeOutput instead of CodeBuffer.

Emit to StreamCodeOutput instead of CodeBuffer.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42801

[Johnni Winther, 2015-01-09 15:05:36]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-01-09 16:35:19]

LGTM.

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/deferre...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/deferre...
pkg/compiler/lib/src/deferred_load.dart:77: /// `true` is this the output unit
for the main output file.
Not english.

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/code...
File pkg/compiler/lib/src/io/code_output.dart (right):

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/code...
pkg/compiler/lib/src/io/code_output.dart:135: String toString() => getText();
I thought we wanted to avoid this, so that one doesn't accidentally drops the
source-markers.

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/sour...
File pkg/compiler/lib/src/io/source_map_builder.dart (right):

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_map_builder.dart:91: return
lineColumnProvider.getLine(position) ==
lineColumnProvider.getLine(otherPosition);
long line.

https://codereview.chromium.org/830703004/diff/1/pkg/dart2js_incremental/.set...
File pkg/dart2js_incremental/.settings/com.google.dart.tools.core.prefs (right):

https://codereview.chromium.org/830703004/diff/1/pkg/dart2js_incremental/.set...
pkg/dart2js_incremental/.settings/com.google.dart.tools.core.prefs:2:
projectPackageRoot=D\:\\dart-repo\\dart\\build\\ReleaseIA32\\packages
This feels weird.

Accidental new file?

[Johnni Winther, 2015-01-13 08:53:05]

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/deferre...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/deferre...
pkg/compiler/lib/src/deferred_load.dart:77: /// `true` is this the output unit
for the main output file.
On 2015/01/09 16:35:19, floitsch wrote:
> Not english.

Done.

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/code...
File pkg/compiler/lib/src/io/code_output.dart (right):

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/code...
pkg/compiler/lib/src/io/code_output.dart:135: String toString() => getText();
On 2015/01/09 16:35:19, floitsch wrote:
> I thought we wanted to avoid this, so that one doesn't accidentally drops the
> source-markers.

We do. Reverted.

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/sour...
File pkg/compiler/lib/src/io/source_map_builder.dart (right):

https://codereview.chromium.org/830703004/diff/1/pkg/compiler/lib/src/io/sour...
pkg/compiler/lib/src/io/source_map_builder.dart:91: return
lineColumnProvider.getLine(position) ==
lineColumnProvider.getLine(otherPosition);
On 2015/01/09 16:35:19, floitsch wrote:
> long line.

Done.

https://codereview.chromium.org/830703004/diff/1/pkg/dart2js_incremental/.set...
File pkg/dart2js_incremental/.settings/com.google.dart.tools.core.prefs (right):

https://codereview.chromium.org/830703004/diff/1/pkg/dart2js_incremental/.set...
pkg/dart2js_incremental/.settings/com.google.dart.tools.core.prefs:2:
projectPackageRoot=D\:\\dart-repo\\dart\\build\\ReleaseIA32\\packages
On 2015/01/09 16:35:19, floitsch wrote:
> This feels weird.
> 
> Accidental new file?

Yes. Removed.

[Johnni Winther, 2015-01-13 09:17:23]

Committed patchset #2 (id:20001) manually as 42801 (presubmit successful).