Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Issue 830463003: dart2js: collect static-non-final fields in the task. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: collect static-non-final fields in the task. R=sigurdm@google.com, zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -27 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 3 chunks +18 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +34 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 11 months ago (2015-01-08 14:40:10 UTC) #2
sigurdm
LGTM
5 years, 11 months ago (2015-01-09 08:01:43 UTC) #3
zarah
LGTM
5 years, 11 months ago (2015-01-09 09:20:46 UTC) #4
floitsch
5 years, 11 months ago (2015-01-09 17:23:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698