Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 830193003: dart2js: set needsTearOff when creating the getter/setter stubs in the new emitter. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, herhut
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: set needsTearOff when creating the getter/setter stubs in the new emitter. The Method constructor requires the booleans to be set: Method(this.element, this.name, this.code, {this.needsTearOff}) { assert(needsTearOff != null); R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 11 months ago (2015-01-21 13:49:51 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-21 13:52:55 UTC) #3
floitsch
5 years, 11 months ago (2015-01-21 14:01:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43037 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698