Issue 830153004: Remove computation with no effect from local completion computer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 830153004: Remove computation with no effect from local completion computer. (Closed)

Created:
5 years, 11 months ago by Paul Berry

Modified:
5 years, 11 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Remove computation with no effect from local completion computer. The computation performed by _computeExcludeVoidReturn was always being overwritten by the caller right after construction, so it had no effect. R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=42752

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -28 lines)			Patch
	M	pkg/analysis_server/lib/src/services/completion/local_computer.dart	View		5 chunks	+14 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 11 months ago (2015-01-09 19:28:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42752 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages