Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 830143003: Optimize DateTime constructor slightly. (Closed)

Created:
5 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Optimize DateTime constructor slightly. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=42656

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix bad edit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M runtime/lib/date_patch.dart View 1 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
5 years, 11 months ago (2015-01-07 10:30:37 UTC) #2
Søren Gjesse
https://codereview.chromium.org/830143003/diff/1/runtime/lib/date_patch.dart File runtime/lib/date_patch.dart (right): https://codereview.chromium.org/830143003/diff/1/runtime/lib/date_patch.dart#newcode150 runtime/lib/date_patch.dart:150: /* patch */ int get millisecond => __[_MILLISECOND_INDEX]; Where ...
5 years, 11 months ago (2015-01-07 10:48:18 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/830143003/diff/1/runtime/lib/date_patch.dart File runtime/lib/date_patch.dart (right): https://codereview.chromium.org/830143003/diff/1/runtime/lib/date_patch.dart#newcode150 runtime/lib/date_patch.dart:150: /* patch */ int get millisecond => __[_MILLISECOND_INDEX]; Ack, ...
5 years, 11 months ago (2015-01-07 12:01:19 UTC) #4
Søren Gjesse
lgtm https://codereview.chromium.org/830143003/diff/1/runtime/lib/date_patch.dart File runtime/lib/date_patch.dart (right): https://codereview.chromium.org/830143003/diff/1/runtime/lib/date_patch.dart#newcode150 runtime/lib/date_patch.dart:150: /* patch */ int get millisecond => __[_MILLISECOND_INDEX]; ...
5 years, 11 months ago (2015-01-07 12:03:29 UTC) #5
Lasse Reichstein Nielsen
5 years, 11 months ago (2015-01-07 13:09:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698