Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 829473003: dart2js: move native boilerplate code into a separate file. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah, sra1
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: move native boilerplate code into a separate file. R=sra@google.com, zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42627

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Reupload #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -64 lines) Patch
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 2 3 1 chunk +1 line, -0 lines 0 comments Download
A pkg/compiler/lib/src/js_emitter/native_generator.dart View 1 chunk +70 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 3 2 chunks +7 lines, -62 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
floitsch
The moved code is as untouched as possible (in this CL).
5 years, 11 months ago (2015-01-05 13:52:46 UTC) #2
zarah
LGTM!
5 years, 11 months ago (2015-01-05 14:10:28 UTC) #3
zarah
LGTM!
5 years, 11 months ago (2015-01-05 14:10:30 UTC) #4
sra1
lgtm
5 years, 11 months ago (2015-01-05 18:51:31 UTC) #5
floitsch
5 years, 11 months ago (2015-01-06 12:25:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 42627 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698