Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 829133007: Enable enum and deferred import support (Closed)

Created:
5 years, 11 months ago by Brian Wilkerson
Modified:
5 years, 11 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Enable enum and deferred import support R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+690 lines, -907 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/context/AnalysisOptions.java View 3 chunks +3 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java View 4 chunks +9 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/context/AnalysisOptionsImplTest.java View 3 chunks +0 lines, -22 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java View 38 chunks +55 lines, -89 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/HintCodeTest.java View 3 chunks +1 line, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 4 chunks +34 lines, -46 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonHintCodeTest.java View 2 chunks +7 lines, -11 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/ResolverTestCase.java View 1 chunk +7 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java View 5 chunks +96 lines, -134 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java View 4 chunks +12 lines, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/options.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 13 chunks +123 lines, -119 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 23 chunks +272 lines, -285 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 36 chunks +28 lines, -63 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 4 chunks +0 lines, -22 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 5 chunks +0 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 7 chunks +3 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 6 chunks +10 lines, -17 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 7 chunks +13 lines, -28 lines 0 comments Download
M pkg/analyzer/test/options_test.dart View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 11 months ago (2015-01-08 17:35:01 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-08 17:40:25 UTC) #3
Brian Wilkerson
5 years, 11 months ago (2015-01-08 17:52:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698