Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 829033004: Non-fatal errors in compile-time constants. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/non_fatal_constants
Visibility:
Public.

Description

Non-fatal errors in compile-time constants. BUG=https://code.google.com/p/dart/issues/detail?id=22018 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42768

Patch Set 1 #

Patch Set 2 : Merged with r42767. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M dart/pkg/compiler/lib/src/compile_time_constants.dart View 1 5 chunks +15 lines, -8 lines 0 comments Download
M dart/pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ahe
5 years, 11 months ago (2015-01-09 15:00:28 UTC) #2
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-09 15:05:13 UTC) #3
ahe
5 years, 11 months ago (2015-01-12 10:17:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698