Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 82903007: Improved HTML parsing (Closed)

Created:
7 years ago by Brian Wilkerson
Modified:
7 years ago
Reviewers:
jwren, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improved HTML parsing. With these changes, we now parse embedded Dart code at the same time that we parse the HTML file, and we have access to the Dart AST structures from the HTML AST structure. We're still resolving embedded Dart scripts when we resolve the HTML, but are not yet resolving embedded expressions (there's a TODO for that; I thought this was enough to review). R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=30638

Patch Set 1 #

Patch Set 2 : Clean-up #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+887 lines, -166 lines) Patch
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/AttributeWithEmbeddedExpressions.java View 1 chunk +46 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/EmbeddedExpression.java View 1 chunk +82 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/HtmlScriptTagNode.java View 1 chunk +98 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/TagWithEmbeddedExpressions.java View 1 chunk +54 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/XmlAttributeNode.java View 1 chunk +9 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/XmlTagNode.java View 2 chunks +9 lines, -1 line 0 comments Download
A editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/visitor/EmbeddedDartVisitor.java View 1 1 chunk +77 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/visitor/RecursiveXmlVisitor.java View 2 chunks +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/visitor/SimpleXmlVisitor.java View 2 chunks +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/visitor/ToSourceVisitor.java View 2 chunks +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/ast/visitor/XmlVisitor.java View 2 chunks +5 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/parser/HtmlParser.java View 1 5 chunks +214 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/html/parser/XmlParser.java View 4 chunks +42 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/HtmlUnitBuilder.java View 7 chunks +98 lines, -123 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/cache/HtmlEntry.java View 1 chunk +7 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/cache/HtmlEntryImpl.java View 10 chunks +33 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/html/HtmlTagInfoBuilder.java View 2 chunks +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/ParseHtmlTask.java View 5 chunks +37 lines, -25 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java View 4 chunks +32 lines, -1 line 4 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/cache/HtmlEntryImplTest.java View 2 chunks +11 lines, -0 lines 7 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/HtmlTagInfoBuilderTest.java View 2 chunks +4 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Wilkerson
7 years ago (2013-11-24 17:07:34 UTC) #1
danrubel
LGTM with suggestions for this or a future CL https://codereview.chromium.org/82903007/diff/20001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java (right): https://codereview.chromium.org/82903007/diff/20001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java#newcode94 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java:94: ...
7 years ago (2013-11-25 02:26:11 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/82903007/diff/20001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java (right): https://codereview.chromium.org/82903007/diff/20001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java#newcode94 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/html/parser/HtmlParserTest.java:94: HtmlUnit htmlUnit = parse("<html><body foo='{{bar}}'></body></html>").getHtmlUnit(); TODO added. Not sure ...
7 years ago (2013-11-25 19:04:36 UTC) #3
Brian Wilkerson
7 years ago (2013-11-25 19:07:06 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r30638 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698