Patch classes do not need to be finalized

Patch classes do not need to be finalized

The fields and functions of a patch class are copied to the
patched class after parsing. There is nothing to do when finalizing
a patch class, so return immediately.

The debugger ran into an overly strict assertion when finalizing
a patch class. This fixes the issue. (Issue 21039).

Committed: https://code.google.com/p/dart/source/detail?r=42612

[hausner, 2015-01-02 23:09:57]

hausner@google.com changed reviewers:
+ iposva@chromium.org

[Ivan Posva, 2015-01-03 01:14:19]

iposva@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2015-01-03 01:14:19]

https://codereview.chromium.org/828353002/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/828353002/diff/1/runtime/vm/class_finalizer.c...
runtime/vm/class_finalizer.cc:2311: // patched class after parsing. There is
nothing to finalize.
We should also make sure that we do not waste a class id on the patch class.

[hausner, 2015-01-05 20:51:55]

Committed patchset #1 (id:1) manually as r42612 (presubmit successful).

[hausner, 2015-01-05 20:56:29]

Thank you.

https://codereview.chromium.org/828353002/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/828353002/diff/1/runtime/vm/class_finalizer.c...
runtime/vm/class_finalizer.cc:2311: // patched class after parsing. There is
nothing to finalize.
On 2015/01/03 01:14:19, Ivan Posva wrote:
> We should also make sure that we do not waste a class id on the patch class.

As per our off-line conversation, I'm leaving this as is. Assigning a class id
is done at the lowest level when allocating a new class object. Changing this
would be outside of this CL.