Issue 828233003: Status file cleanup: consolidate sections and sort lines for co19.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 828233003: Status file cleanup: consolidate sections and sort lines for co19. (Closed)

Created:
5 years, 11 months ago by Bill Hesse

Modified:
5 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Status file cleanup: consolidate sections and sort lines for co19. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=42911

Patch Set 2 : Address comment. #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+383 lines, -561 lines)			Patch
M	tests/co19/co19-dart2dart.status	View	1	3 chunks	+66 lines, -65 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		12 chunks	+316 lines, -496 lines	0 comments	Download
M	tests/co19/co19-dartium.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

lgtm https://codereview.chromium.org/828233003/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/828233003/diff/1/tests/co19/co19-dart2dart.status#newcode107 tests/co19/co19-dart2dart.status:107: LibTest/math/tan_A01_t01: Fail # Issue co19 - 44 change ...

5 years, 11 months ago (2015-01-15 14:41:02 UTC) #3

Bill Hesse

5 years, 11 months ago (2015-01-15 14:44:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42911 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 828233003: Status file cleanup: consolidate sections and sort lines for co19. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages