Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 827763003: Reapply "Allow LetCont to bind multiple continuations." (Closed)

Created:
5 years, 11 months ago by Kevin Millikin (Google)
Modified:
5 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Reapply "Allow LetCont to bind multiple continuations." This reapplies svn revision r42945 with bugfixes. There was an invalid assertion in the shrinking reduction pass and a stray left parenthesis in one of the input IR expressions. Some of the logic in the shrinking reduction pass has been cleaned up. R=asgerf@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1096 lines, -910 lines) Patch
M pkg/analyzer2dart/test/sexpr_data.dart View 61 chunks +310 lines, -310 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 16 chunks +69 lines, -60 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 8 chunks +30 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 2 chunks +25 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_phi.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 16 chunks +79 lines, -55 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +20 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_constprop_test.dart View 11 chunks +286 lines, -224 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 8 chunks +168 lines, -123 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 7 chunks +68 lines, -68 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 4 chunks +20 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_basic_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
5 years, 11 months ago (2015-01-19 12:01:05 UTC) #1
asgerf
lgtm
5 years, 11 months ago (2015-01-19 12:31:40 UTC) #2
Kevin Millikin (Google)
5 years, 11 months ago (2015-01-19 12:50:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698