Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 827343003: Perform incremental resolution only if the existing unit is not null. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Perform incremental resolution only if the existing unit is not null. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 11 months ago (2014-12-31 19:21:17 UTC) #1
Brian Wilkerson
LGTM
5 years, 11 months ago (2014-12-31 21:12:41 UTC) #2
scheglov
5 years, 11 months ago (2014-12-31 23:38:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698