Issue 82693004: Fix function subtyping bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 82693004: Fix function subtyping bug. (Closed)

Created:
7 years, 1 month ago by Johnni Winther

Modified:
7 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix function subtyping bug. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=30609

Patch Set 2 : Updated cf. comments. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -4 lines)			Patch
	M	sdk/lib/_internal/lib/js_rti.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
	A	tests/language/function_subtype2_test.dart	View	1	1 chunk	+140 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

karlklose

Should the text description in the Expect.isFalse cases use 'is not'? https://codereview.chromium.org/82693004/diff/1/tests/language/function_subtype2_test.dart File tests/language/function_subtype2_test.dart (right): ...

7 years, 1 month ago (2013-11-22 13:14:05 UTC) #2

Johnni Winther

https://codereview.chromium.org/82693004/diff/1/tests/language/function_subtype2_test.dart File tests/language/function_subtype2_test.dart (right): https://codereview.chromium.org/82693004/diff/1/tests/language/function_subtype2_test.dart#newcode32 tests/language/function_subtype2_test.dart:32: Expect.isTrue(c1.m2 is T1, "(int,[int])->void is (int,[int])->void"); On 2013/11/22 13:14:05, ...

7 years ago (2013-11-25 07:28:57 UTC) #4

Johnni Winther

7 years ago (2013-11-25 07:30:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r30609 (presubmit successful).

Expand Messages | Collapse Messages

Issue 82693004: Fix function subtyping bug. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Updated cf. comments. #

Messages