Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 825553002: Update a couple other references to sunflower that I missed (Closed)

Created:
6 years ago by Siggi Cherem (dart-lang)
Modified:
5 years, 11 months ago
Reviewers:
nweiz, ahe
CC:
reviews_dartlang.org, ricow1, ahe
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Update a couple other references to sunflower that I missed R=nweiz BUG= Committed: https://code.google.com/p/dart/source/detail?r=42559

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M site/try/src/samples.dart View 1 chunk +1 line, -1 line 2 comments Download
M tests/compiler/dart2js/source_map_pub_build_validity_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Siggi Cherem (dart-lang)
6 years ago (2014-12-22 23:51:55 UTC) #1
Siggi Cherem (dart-lang)
+ahe - now that sunflower is downloaded via DEPS, the reference to the sample folder ...
6 years ago (2014-12-22 23:53:04 UTC) #2
Siggi Cherem (dart-lang)
6 years ago (2014-12-22 23:53:28 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 42559 (presubmit successful).
6 years ago (2014-12-22 23:53:38 UTC) #4
nweiz
lgtm https://codereview.chromium.org/825553002/diff/1/site/try/src/samples.dart File site/try/src/samples.dart (right): https://codereview.chromium.org/825553002/diff/1/site/try/src/samples.dart#newcode136 site/try/src/samples.dart:136: "https://raw.githubusercontent.com/dart-lang/sample-sunflower/f808fcf68e523ea69631d2e61fd26be3296a1a8f/web/math.png"; long line
5 years, 11 months ago (2015-01-05 19:52:30 UTC) #5
ahe
5 years, 11 months ago (2015-01-07 12:09:33 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/825553002/diff/1/site/try/src/samples.dart
File site/try/src/samples.dart (right):

https://codereview.chromium.org/825553002/diff/1/site/try/src/samples.dart#ne...
site/try/src/samples.dart:136:
"https://raw.githubusercontent.com/dart-lang/sample-sunflower/f808fcf68e523ea69631d2e61fd26be3296a1a8f/web/math.png";
On 2015/01/05 19:52:30, nweiz wrote:
> long line

Don't worry about that. I should copy the PNG file when I build Try Dart. I'm
tracking that in https://code.google.com/p/dart/issues/detail?id=22006.

Powered by Google App Engine
This is Rietveld 408576698