Fix http://dartbug.com/21834

Fix http://dartbug.com/21834
- Ensure that microtasks fire after every timer event, instead
  of being bunched together once all pending timers fired.
- Do not wait for timer message to be delivered. Trigger timers
  as soon as they are ready from within the message handling
  loop.
- Notify timers in the order of wakeup time regardless of
  specified timeout value. (AKA Do not allow Timer.run to
  overtake new Timer() scheduled operations.)

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42673

[Ivan Posva, 2015-01-07 00:13:08]

iposva@google.com changed reviewers:
+ asiva@google.com, lrn@google.com, zra@google.com

[Ivan Posva, 2015-01-07 00:13:09]

https://codereview.chromium.org/825403003/diff/40001/tests/lib/mirrors/invoca...
File tests/lib/mirrors/invocation_fuzz_test.dart (right):

https://codereview.chromium.org/825403003/diff/40001/tests/lib/mirrors/invoca...
tests/lib/mirrors/invocation_fuzz_test.dart:181: "foo", 'blåbærgrød',
'Îñţérñåţîöñåļîžåţîờñ', "턞", #symbol];
Ryan, what was the expected /xyz encoding here?

[rmacnak, 2015-01-07 00:29:25]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-01-07 00:29:25]

https://codereview.chromium.org/825403003/diff/40001/tests/lib/mirrors/invoca...
File tests/lib/mirrors/invocation_fuzz_test.dart (right):

https://codereview.chromium.org/825403003/diff/40001/tests/lib/mirrors/invoca...
tests/lib/mirrors/invocation_fuzz_test.dart:181: "foo", 'blåbærgrød',
'Îñţérñåţîöñåļîžåţîờñ', "턞", #symbol];
On 2015/01/07 00:13:09, Ivan Posva wrote:
> Ryan, what was the expected /xyz encoding here?

This was "\u{1D11E}", or whatever string you like that includes surrogate pairs.

[zra, 2015-01-07 15:48:03]

https://codereview.chromium.org/825403003/diff/40001/sdk/lib/io/timer_impl.dart
File sdk/lib/io/timer_impl.dart (right):

https://codereview.chromium.org/825403003/diff/40001/sdk/lib/io/timer_impl.da...
sdk/lib/io/timer_impl.dart:205: // the given timer is the earliest timer the
native timer is reset.
"the native timer is reset" -> "the event handler is notified"?

https://codereview.chromium.org/825403003/diff/40001/sdk/lib/io/timer_impl.da...
sdk/lib/io/timer_impl.dart:297: ((heapTime == listTime) &&
(heapTime == listTime) implies that both heapTime and listTime are <=
currentTime, so I don't think checking _firstZeroTimer for null is needed. If it
is needed, then checking _firstZeroTimer for null is also needed in the else
branch below.

Also, maybe this condition is complex enough to be pulled out into a function,
like "shouldTakeFromHeap" or something like that.

[Ivan Posva, 2015-01-07 20:52:01]

PTAL

Also ensured to avoid redundant event handler notifications.

-Ivan

https://codereview.chromium.org/825403003/diff/40001/sdk/lib/io/timer_impl.dart
File sdk/lib/io/timer_impl.dart (right):

https://codereview.chromium.org/825403003/diff/40001/sdk/lib/io/timer_impl.da...
sdk/lib/io/timer_impl.dart:205: // the given timer is the earliest timer the
native timer is reset.
On 2015/01/07 15:48:03, zra wrote:
> "the native timer is reset" -> "the event handler is notified"?

Done.

https://codereview.chromium.org/825403003/diff/40001/sdk/lib/io/timer_impl.da...
sdk/lib/io/timer_impl.dart:297: ((heapTime == listTime) &&
On 2015/01/07 15:48:03, zra wrote:
> (heapTime == listTime) implies that both heapTime and listTime are <=
> currentTime, so I don't think checking _firstZeroTimer for null is needed. If
it
> is needed, then checking _firstZeroTimer for null is also needed in the else
> branch below.
> 
> Also, maybe this condition is complex enough to be pulled out into a function,
> like "shouldTakeFromHeap" or something like that.

Simplified the expression and added an assertion after convincing you and me
that null cannot be bubbling into the comparison.

https://codereview.chromium.org/825403003/diff/40001/tests/lib/mirrors/invoca...
File tests/lib/mirrors/invocation_fuzz_test.dart (right):

https://codereview.chromium.org/825403003/diff/40001/tests/lib/mirrors/invoca...
tests/lib/mirrors/invocation_fuzz_test.dart:181: "foo", 'blåbærgrød',
'Îñţérñåţîöñåļîžåţîờñ', "턞", #symbol];
On 2015/01/07 00:29:25, rmacnak wrote:
> On 2015/01/07 00:13:09, Ivan Posva wrote:
> > Ryan, what was the expected /xyz encoding here?
> 
> This was "\u{1D11E}", or whatever string you like that includes surrogate
pairs.

Thanks!

[zra, 2015-01-07 20:57:53]

lgtm

[Ivan Posva, 2015-01-07 22:22:06]

Committed patchset #4 (id:60001) manually as r42673 (presubmit successful).