Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 824873003: Process two 32-bit digits as one 64-bit digit in bigint absAdd an absSub (Closed)

Created:
6 years ago by regis
Modified:
6 years ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Process two 32-bit digits as one 64-bit digit in bigint absAdd an absSub intrinsics on ARM64. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=42564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M runtime/vm/intrinsifier_arm64.cc View 6 chunks +35 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
Hi Zach, It's a simple change that was done earlier on X64. The difficulty was ...
6 years ago (2014-12-23 17:56:25 UTC) #1
regis
6 years ago (2014-12-23 17:57:10 UTC) #3
zra
lgtm and verified RSA benchmark runs on hardware.
6 years ago (2014-12-23 18:25:37 UTC) #4
regis
6 years ago (2014-12-23 18:28:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42564 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698