Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 824103005: Revert "Remove Compiler.assembledCode." (Closed)

Created:
5 years, 11 months ago by Johnni Winther
Modified:
5 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Revert "Remove Compiler.assembledCode." This reverts commit r42592. BUG= Committed: https://code.google.com/p/dart/source/detail?r=42594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -236 lines) Patch
M pkg/compiler/lib/compiler.dart View 3 chunks +15 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 6 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/outputter.dart View 6 chunks +13 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_backend_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_new_backend_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/end2end_test.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/test_helper.dart View 1 chunk +2 lines, -5 lines 0 comments Download
A tests/compiler/dart2js/compiler_alt.dart View 1 chunk +48 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 7 chunks +23 lines, -27 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 3 chunks +22 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 3 chunks +36 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mirror_helper_rename_test.dart View 4 chunks +6 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +2 lines, -4 lines 0 comments Download
D tests/compiler/dart2js/output_collector.dart View 1 chunk +0 lines, -44 lines 0 comments Download
M tests/compiler/dart2js/source_map_d2js_validity_test.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/source_map_deferred_d2js_validity_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/uri_retention_test.dart View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
TBR
5 years, 11 months ago (2015-01-05 14:37:00 UTC) #2
Johnni Winther
Committed patchset #1 (id:1) manually as 42594 (presubmit successful).
5 years, 11 months ago (2015-01-05 14:39:08 UTC) #3
floitsch
5 years, 11 months ago (2015-01-05 14:39:24 UTC) #4
Message was sent while issue was closed. 
LGTM :(

Powered by Google App Engine
This is Rietveld 408576698