Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 82373002: Fix filtering out .dart files in release mode. (Closed)

Created:
7 years, 1 month ago by Bob Nystrom
Modified:
7 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org, dgrove, ricow1
Visibility:
Public.

Description

Fix filtering out .dart files in release mode. BUG=https://code.google.com/p/dart/issues/detail?id=15183 Committed: https://code.google.com/p/dart/source/detail?r=30560

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -11 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart View 1 chunk +5 lines, -1 line 2 comments Download
M sdk/lib/_internal/pub/lib/src/barback/server.dart View 3 chunks +18 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/build.dart View 5 chunks +17 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/build/copies_browser_js_next_to_entrypoints_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A sdk/lib/_internal/pub/test/build/dart2js_finds_imports_across_packages_test.dart View 1 chunk +59 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/does_not_serve_dart_in_release_test.dart View 1 chunk +22 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
7 years, 1 month ago (2013-11-22 01:16:34 UTC) #1
Bob Nystrom
Committed patchset #1 manually as r30560 (presubmit successful).
7 years, 1 month ago (2013-11-22 01:25:30 UTC) #2
Bob Nystrom
TBR-ing this so it can get into the next build.
7 years, 1 month ago (2013-11-22 01:27:59 UTC) #3
nweiz
One change, otherwise lgtm. https://codereview.chromium.org/82373002/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right): https://codereview.chromium.org/82373002/diff/1/sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart#newcode24 sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:24: /// the end of every ...
7 years, 1 month ago (2013-11-22 20:24:30 UTC) #4
Bob Nystrom
7 years ago (2013-12-03 19:21:55 UTC) #5
Message was sent while issue was closed.
Fixed here: https://codereview.chromium.org/102433004/

https://codereview.chromium.org/82373002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right):

https://codereview.chromium.org/82373002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:24: /// the end
of every package's cascade.
On 2013/11/22 20:24:30, nweiz wrote:
> This documentation needs to be updated. It may also be a good idea to change
the
> name of [builtInTransformers] to something like
> [additionalEntrypointTransformers].

Fixed the docs. The name is already a mouthful, so I left that alone.

Powered by Google App Engine
This is Rietveld 408576698