Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 823123004: Display overlays at /overlays URI. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -168 lines) Patch
M pkg/analysis_server/lib/src/get_handler.dart View 4 chunks +47 lines, -1 line 2 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 21 chunks +177 lines, -167 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
5 years, 11 months ago (2015-01-14 23:18:05 UTC) #1
Brian Wilkerson
LGTM as a first step
5 years, 11 months ago (2015-01-14 23:43:58 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/823123004/diff/1/pkg/analysis_server/lib/src/get_handler.dart File pkg/analysis_server/lib/src/get_handler.dart (right): https://codereview.chromium.org/823123004/diff/1/pkg/analysis_server/lib/src/get_handler.dart#newcode404 pkg/analysis_server/lib/src/get_handler.dart:404: response.write('<td>${HTML_ESCAPE.convert('$source')}</td>'); Maybe enclose this in <pre> so it ...
5 years, 11 months ago (2015-01-15 00:07:06 UTC) #3
scheglov
https://codereview.chromium.org/823123004/diff/1/pkg/analysis_server/lib/src/get_handler.dart File pkg/analysis_server/lib/src/get_handler.dart (right): https://codereview.chromium.org/823123004/diff/1/pkg/analysis_server/lib/src/get_handler.dart#newcode404 pkg/analysis_server/lib/src/get_handler.dart:404: response.write('<td>${HTML_ESCAPE.convert('$source')}</td>'); On 2015/01/15 00:07:06, Paul Berry wrote: > Maybe ...
5 years, 11 months ago (2015-01-15 00:22:15 UTC) #4
scheglov
5 years, 11 months ago (2015-01-15 00:22:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42891 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698