Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 822593004: dart2js: Let the emitter generate the program. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Let the emitter generate the program. This gives the emitter the option to pass options to the builder. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43035

Patch Set 1 #

Patch Set 2 : No need to pass the task to the new emitter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 11 months ago (2015-01-20 16:35:09 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-21 08:26:57 UTC) #3
zarah
LGTM
5 years, 11 months ago (2015-01-21 08:26:59 UTC) #4
floitsch
5 years, 11 months ago (2015-01-21 12:04:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43035 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698