Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 821593004: Create erroneous element when resolution of initializer fails. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/erroneous_field
Visibility:
Public.

Description

Create erroneous element when resolution of initializer fails. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42729

Patch Set 1 : #

Patch Set 2 : Tests passing locally. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -56 lines) Patch
M dart/pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +73 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/members.dart View 1 3 chunks +5 lines, -9 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +27 lines, -24 lines 0 comments Download
M dart/pkg/compiler/lib/src/typechecker.dart View 1 2 chunks +6 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/resolver_test.dart View 1 4 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ahe
5 years, 11 months ago (2015-01-08 13:52:49 UTC) #5
ahe
PTAL, ready for review and all tests are passing locally.
5 years, 11 months ago (2015-01-08 23:23:32 UTC) #7
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-09 08:12:32 UTC) #8
ahe
5 years, 11 months ago (2015-01-09 10:50:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:100001) manually as 42729 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698