Simplify double to bigint conversion.

Simplify double to bigint conversion.
Remove 3 bigint mutators.
Remove unused support to create vm internal error.

R=rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42842

[regis, 2015-01-13 20:27:49]

regis@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-01-13 21:22:43]

lgtm

https://codereview.chromium.org/821123003/diff/1/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (left):

https://codereview.chromium.org/821123003/diff/1/runtime/lib/bigint.dart#oldc...
runtime/lib/bigint.dart:83: factory _Bigint._fromHex(String s) {
Was this used by int.parse before? Do we have a fast path for loading a bigint
from a hex string (e.g. loading an large key from a file)?

[regis, 2015-01-13 21:29:30]

Thanks!

https://codereview.chromium.org/821123003/diff/1/runtime/lib/bigint.dart
File runtime/lib/bigint.dart (left):

https://codereview.chromium.org/821123003/diff/1/runtime/lib/bigint.dart#oldc...
runtime/lib/bigint.dart:83: factory _Bigint._fromHex(String s) {
On 2015/01/13 21:22:43, rmacnak wrote:
> Was this used by int.parse before? Do we have a fast path for loading a bigint
> from a hex string (e.g. loading an large key from a file)?

Currently, we only use a C++ version: Bigint::NewFromHexCString.
An earlier version of this method was used in the RSA benchmark to parse a hex
key. It's why it was added here, but was never used.

[regis, 2015-01-13 21:29:49]

Committed patchset #1 (id:1) manually as r42842 (presubmit successful).