Issue 820883004: Move ConstantPropagator from flow_graph_optimizer.cc/.h into separate files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 820883004: Move ConstantPropagator from flow_graph_optimizer.cc/.h into separate files. (Closed)

Created:
5 years, 11 months ago by Florian Schneider

Modified:
5 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move ConstantPropagator from flow_graph_optimizer.cc/.h into separate files. flow_graph_optimizer.cc is becoming unnecessarily large, so I'm moving self-contained optimization passes into separate files. In a separate CL I'll also move load/store optimization into separate files. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=42567

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -10569 lines)			Patch
M	runtime/vm/compiler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	runtime/vm/constant_propagator.h	View	3 chunks	+3 lines, -424 lines	0 comments	Download
A +	runtime/vm/constant_propagator.cc	View	3 chunks	+2 lines, -8451 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+0 lines, -77 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	2 chunks	+0 lines, -1616 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

5 years, 11 months ago (2014-12-29 14:41:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r42567 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages