Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 82043002: Source kind arg support for dartftmt. (Closed)

Created:
7 years, 1 month ago by pquitslund
Modified:
7 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Source kind arg support for dartftmt. The API is far from firm but enough to enable a steel-thread through the editor where we want to support formatting source selections. A follow-up CL will introduce more CodeKinds. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=30584

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M pkg/analyzer/bin/formatter.dart View 1 7 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
7 years, 1 month ago (2013-11-21 23:44:57 UTC) #1
Brian Wilkerson
LGTM
7 years ago (2013-11-22 14:13:56 UTC) #2
pquitslund
7 years ago (2013-11-22 18:50:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698