Issue 819183005: Wrap standalone invariant() calls in assert().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 819183005: Wrap standalone invariant() calls in assert(). (Closed)

Created:
5 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
5 years, 11 months ago

Reviewers:
Johnni Winther, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Wrap standalone invariant() calls in assert(). To avoid unnecessary allocation: some of them have closure as an argument. R=floitsch@google.com, johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42878

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -11 lines)			Patch
	M	pkg/compiler/lib/src/dart_types.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/resolution/members.dart	View	1	4 chunks	+24 lines, -10 lines	0 comments	Download

Total messages: 6 (1 generated)

floitsch

LGTM, but maybe wait a bit to give Johnni a chance to review.

5 years, 11 months ago (2015-01-12 17:45:14 UTC) #3

Vyacheslav Egorov (Google)

Johnni, please take another look. I reverted changes in those files that did not bother ...

5 years, 11 months ago (2015-01-13 14:38:30 UTC) #4

Vyacheslav Egorov (Google)

5 years, 11 months ago (2015-01-14 18:06:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42878 (presubmit successful).