Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 818543003: dart2js: Remove (some) unused imports. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther, sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Remove (some) unused imports. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=42947

Patch Set 1 #

Total comments: 2

Patch Set 2 : show Hasher from sha1 import. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 11 months ago (2015-01-15 21:12:14 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/818543003/diff/1/pkg/compiler/lib/src/js_emitter/js_emitter.dart File pkg/compiler/lib/src/js_emitter/js_emitter.dart (left): https://codereview.chromium.org/818543003/diff/1/pkg/compiler/lib/src/js_emitter/js_emitter.dart#oldcode92 pkg/compiler/lib/src/js_emitter/js_emitter.dart:92: import '../hash/sha1.dart'; Sha1 was a double-import. It might ...
5 years, 11 months ago (2015-01-16 07:38:35 UTC) #3
floitsch
https://codereview.chromium.org/818543003/diff/1/pkg/compiler/lib/src/js_emitter/js_emitter.dart File pkg/compiler/lib/src/js_emitter/js_emitter.dart (left): https://codereview.chromium.org/818543003/diff/1/pkg/compiler/lib/src/js_emitter/js_emitter.dart#oldcode92 pkg/compiler/lib/src/js_emitter/js_emitter.dart:92: import '../hash/sha1.dart'; On 2015/01/16 07:38:35, sigurdm wrote: > Sha1 ...
5 years, 11 months ago (2015-01-16 09:09:48 UTC) #4
floitsch
5 years, 11 months ago (2015-01-16 09:10:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698