Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 818173003: Use all library units for hints during incremental resolution. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use all library units for hints during incremental resolution. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -35 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +29 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 14 chunks +42 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +80 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 11 months ago (2015-01-13 23:19:14 UTC) #1
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-13 23:22:21 UTC) #2
scheglov
5 years, 11 months ago (2015-01-13 23:23:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698