Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 816773002: Add AccessSemantics support for calling typenames. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Johnni Winther
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add AccessSemantics support for calling typenames. This adds AccessSemantics support for constructions like: class C {} main() { C(); } Even though this will always lead to a runtime error, it only produces a warning at compile time. Therefore AccessSemantics needs to classify it correctly in order to allow the compilation back-end to produce the correct runtime error. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42480

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -171 lines) Patch
M pkg/analyzer2dart/lib/src/identifier_semantics.dart View 8 chunks +77 lines, -53 lines 0 comments Download
M pkg/analyzer2dart/test/identifier_semantics_test.dart View 24 chunks +283 lines, -118 lines 4 comments Download

Messages

Total messages: 6 (1 generated)
Paul Berry
Apologies for the extra code motion--the last time I edited this file was before I'd ...
6 years ago (2014-12-18 21:10:30 UTC) #2
Paul Berry
6 years ago (2014-12-18 21:10:49 UTC) #3
scheglov
lgtm https://codereview.chromium.org/816773002/diff/1/pkg/analyzer2dart/test/identifier_semantics_test.dart File pkg/analyzer2dart/test/identifier_semantics_test.dart (right): https://codereview.chromium.org/816773002/diff/1/pkg/analyzer2dart/test/identifier_semantics_test.dart#newcode679 pkg/analyzer2dart/test/identifier_semantics_test.dart:679: class A; class A {} https://codereview.chromium.org/816773002/diff/1/pkg/analyzer2dart/test/identifier_semantics_test.dart#newcode1249 pkg/analyzer2dart/test/identifier_semantics_test.dart:1249: class ...
6 years ago (2014-12-18 21:19:35 UTC) #4
Paul Berry
https://codereview.chromium.org/816773002/diff/1/pkg/analyzer2dart/test/identifier_semantics_test.dart File pkg/analyzer2dart/test/identifier_semantics_test.dart (right): https://codereview.chromium.org/816773002/diff/1/pkg/analyzer2dart/test/identifier_semantics_test.dart#newcode679 pkg/analyzer2dart/test/identifier_semantics_test.dart:679: class A; On 2014/12/18 21:19:35, scheglov wrote: > class ...
6 years ago (2014-12-18 21:56:58 UTC) #5
Paul Berry
6 years ago (2014-12-18 21:59:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698