refactor/cleanup dart completion cache

refactor/cleanup dart completion cache

BUG=
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42556

[danrubel, 2014-12-20 19:18:54]

danrubel@google.com changed reviewers:
+ paulberry@google.com, scheglov@google.com

[scheglov, 2014-12-21 04:38:05]

lgtm

https://codereview.chromium.org/816233002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart
(right):

https://codereview.chromium.org/816233002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart:92:
_objectClassElement = coreNamespace.definedNames['Object'];
Using Namespace seems too heavyweight here.
You could use LibraryElement.getType().

[danrubel, 2014-12-22 22:06:11]

https://codereview.chromium.org/816233002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart
(right):

https://codereview.chromium.org/816233002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart:92:
_objectClassElement = coreNamespace.definedNames['Object'];
On 2014/12/21 04:38:05, scheglov wrote:
> Using Namespace seems too heavyweight here.
> You could use LibraryElement.getType().

Great suggestion. Done.

[danrubel, 2014-12-22 22:09:54]

Committed patchset #2 (id:20001) manually as 42556 (presubmit successful).