Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 816133002: Improve tests for refactoring exceptions. Catch initial exceptions. (Closed)

Created:
6 years ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Improve tests for refactoring exceptions. Catch initial exceptions. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42574

Patch Set 1 #

Patch Set 2 : Use runZoned(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -38 lines) Patch
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 3 chunks +43 lines, -35 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 3 chunks +36 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years ago (2014-12-19 23:17:57 UTC) #1
Brian Wilkerson
LGTM
6 years ago (2014-12-20 01:21:52 UTC) #2
scheglov
5 years, 11 months ago (2014-12-30 18:51:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698