Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 815233002: Catch exceptions in refactorings and return them as a SERVER_ERROR. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 3 chunks +15 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years ago (2014-12-19 21:20:02 UTC) #1
Brian Wilkerson
LGTM
6 years ago (2014-12-19 21:36:33 UTC) #2
scheglov
6 years ago (2014-12-19 21:51:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698