Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 815123002: Incremental compilation of libraries with multiple parts. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Incremental compilation of libraries with multiple parts. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42506

Patch Set 1 #

Total comments: 9

Patch Set 2 : Merged with r42505. #

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -38 lines) Patch
M dart/pkg/compiler/lib/src/script.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 2 5 chunks +105 lines, -33 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 2 5 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ahe
6 years ago (2014-12-19 11:39:20 UTC) #2
Johnni Winther
https://codereview.chromium.org/815123002/diff/1/dart/pkg/compiler/lib/src/script.dart File dart/pkg/compiler/lib/src/script.dart (right): https://codereview.chromium.org/815123002/diff/1/dart/pkg/compiler/lib/src/script.dart#newcode30 dart/pkg/compiler/lib/src/script.dart:30: Script copyWithFile(SourceFile file) { Add comment. https://codereview.chromium.org/815123002/diff/1/dart/pkg/dart2js_incremental/lib/library_updater.dart File dart/pkg/dart2js_incremental/lib/library_updater.dart ...
6 years ago (2014-12-19 12:17:33 UTC) #3
Johnni Winther
https://codereview.chromium.org/815123002/diff/1/dart/pkg/compiler/lib/src/script.dart File dart/pkg/compiler/lib/src/script.dart (right): https://codereview.chromium.org/815123002/diff/1/dart/pkg/compiler/lib/src/script.dart#newcode30 dart/pkg/compiler/lib/src/script.dart:30: Script copyWithFile(SourceFile file) { On 2014/12/19 12:17:33, Johnni Winther ...
6 years ago (2014-12-19 12:54:24 UTC) #4
Johnni Winther
lgtm
6 years ago (2014-12-19 12:54:42 UTC) #5
ahe
Thank you, Johnni. PTAL. https://codereview.chromium.org/815123002/diff/1/dart/pkg/compiler/lib/src/script.dart File dart/pkg/compiler/lib/src/script.dart (right): https://codereview.chromium.org/815123002/diff/1/dart/pkg/compiler/lib/src/script.dart#newcode30 dart/pkg/compiler/lib/src/script.dart:30: Script copyWithFile(SourceFile file) { On ...
6 years ago (2014-12-19 13:35:46 UTC) #6
Johnni Winther
LGTM and I mean it this time.
6 years ago (2014-12-19 13:42:30 UTC) #7
ahe
6 years ago (2014-12-19 13:44:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 42506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698